Skip to content

[SC 8504] Missing definition of the parameters in the capital markets model notebook#315

Merged
AnilSorathiya merged 2 commits intoprodfrom
anilsorathiya/sc-8504/define-missing-parameters-in-the-capital-markets-model-notebook
Feb 11, 2025
Merged

[SC 8504] Missing definition of the parameters in the capital markets model notebook#315
AnilSorathiya merged 2 commits intoprodfrom
anilsorathiya/sc-8504/define-missing-parameters-in-the-capital-markets-model-notebook

Conversation

@AnilSorathiya
Copy link
Contributor

Internal Notes for Reviewers

  • Fix notebook quickstart_option_pricing_models.ipynb

@AnilSorathiya AnilSorathiya added bug Something isn't working internal Not to be externalized in the release notes labels Feb 11, 2025
Copy link
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@github-actions
Copy link
Contributor

PR Summary

This pull request introduces enhancements to the notebooks/code_samples/capital_markets/quickstart_option_pricing_models.ipynb notebook by adding two new parameters, N and M, which are likely used for configuring the number of simulations or iterations in the option pricing models. These parameters are initialized with values 10000 and 100, respectively. This change aims to provide more flexibility and control over the synthetic data generation process within the notebook.

The PR also includes a version bump from 2.7.8 to 2.7.9 in the pyproject.toml and validmind/__version__.py files, which is a standard practice for tracking changes but does not affect the functional aspects of the code.

Test Suggestions

  • Verify that the notebook runs without errors after the introduction of the new parameters N and M.
  • Check if the new parameters N and M are utilized correctly in the notebook's code cells.
  • Ensure that the output of the notebook remains consistent with expected results after the changes.
  • Test the notebook with different values for N and M to ensure flexibility and robustness.

Copy link
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@AnilSorathiya AnilSorathiya merged commit d71ee16 into prod Feb 11, 2025
6 checks passed
@johnwalz97 johnwalz97 deleted the anilsorathiya/sc-8504/define-missing-parameters-in-the-capital-markets-model-notebook branch August 20, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants